osp 3rd cycle presentation - konkukdslab.konkuk.ac.kr/.../team_project/7th/t3_presentation.pdf ·...

20
OSP 3 rd Cycle Presentation -VAT Paint- T3 / 양승민 정세진 한종철 1 / 20

Upload: others

Post on 27-Jun-2020

3 views

Category:

Documents


0 download

TRANSCRIPT

Page 1: OSP 3rd Cycle Presentation - Konkukdslab.konkuk.ac.kr/.../Team_project/7th/T3_Presentation.pdf · 2013-06-14 · OSP 3. rd. Cycle (VAT Paint) – T3. Clover – Treemap, Cloud Report

OSP 3rd Cycle Presentation

-VAT Paint-

T3 / 양승민 정세진 한종철

1 / 20

Page 2: OSP 3rd Cycle Presentation - Konkukdslab.konkuk.ac.kr/.../Team_project/7th/T3_Presentation.pdf · 2013-06-14 · OSP 3. rd. Cycle (VAT Paint) – T3. Clover – Treemap, Cloud Report

CONTENTS

• Response to System Test

• Response to Static Analysis

• Unit Test

• Concluding Team Project

2 / 20

Page 3: OSP 3rd Cycle Presentation - Konkukdslab.konkuk.ac.kr/.../Team_project/7th/T3_Presentation.pdf · 2013-06-14 · OSP 3. rd. Cycle (VAT Paint) – T3. Clover – Treemap, Cloud Report

Response to System Test

3 / 20

Page 4: OSP 3rd Cycle Presentation - Konkukdslab.konkuk.ac.kr/.../Team_project/7th/T3_Presentation.pdf · 2013-06-14 · OSP 3. rd. Cycle (VAT Paint) – T3. Clover – Treemap, Cloud Report

OSP 3rd Cycle (VAT Paint) – T3

Response to System Test

206 Test Cases

PASSED All TESTS

4 / 20

Page 5: OSP 3rd Cycle Presentation - Konkukdslab.konkuk.ac.kr/.../Team_project/7th/T3_Presentation.pdf · 2013-06-14 · OSP 3. rd. Cycle (VAT Paint) – T3. Clover – Treemap, Cloud Report

Response to Static Analysis

5 / 20

Page 6: OSP 3rd Cycle Presentation - Konkukdslab.konkuk.ac.kr/.../Team_project/7th/T3_Presentation.pdf · 2013-06-14 · OSP 3. rd. Cycle (VAT Paint) – T3. Clover – Treemap, Cloud Report

OSP 3rd Cycle (VAT Paint) – T3

Clover – Coverage Report Coverage Rate

6 / 20

Response to Static Analysis

Presenter
Presentation Notes
SV팀에서 Clover를 이용하여 code coverage rate를 측정하였는데 83.9%가 나왔다. 가장 작은 coverage rate를 보인 SpecialEffect.java의 경우 SV팀에서 Test Case를 부족하게 입력하여서 이런 결과가 나왔다고 report 하였다. rate가 전체적으로 높은 편이고 필요 없는 코드는 없는 것으로 판단되어 특별한 조치를 취하지 않았다.
Page 7: OSP 3rd Cycle Presentation - Konkukdslab.konkuk.ac.kr/.../Team_project/7th/T3_Presentation.pdf · 2013-06-14 · OSP 3. rd. Cycle (VAT Paint) – T3. Clover – Treemap, Cloud Report

OSP 3rd Cycle (VAT Paint) – T3

Clover – Treemap, Cloud Report Complexity

7 / 20

Response to Static Analysis

Page 8: OSP 3rd Cycle Presentation - Konkukdslab.konkuk.ac.kr/.../Team_project/7th/T3_Presentation.pdf · 2013-06-14 · OSP 3. rd. Cycle (VAT Paint) – T3. Clover – Treemap, Cloud Report

OSP 3rd Cycle (VAT Paint) – T3

Clover – Treemap, Cloud Report Complexity SpecialEffect.java

Removed ‘if-else’ construction

8 / 20

Response to Static Analysis

Presenter
Presentation Notes
SpecialEffect.java 에서 같은 기능을 하지만 if-else로 중첩되어 있는 부분을 위의 그림과 같이 수정하여 complexity가 작아지도록 하였다.
Page 9: OSP 3rd Cycle Presentation - Konkukdslab.konkuk.ac.kr/.../Team_project/7th/T3_Presentation.pdf · 2013-06-14 · OSP 3. rd. Cycle (VAT Paint) – T3. Clover – Treemap, Cloud Report

OSP 3rd Cycle (VAT Paint) – T3

Clover – Treemap, Cloud Report Complexity DrawTool.java

Removed ‘switch’ construction

9 / 20

Response to Static Analysis

Presenter
Presentation Notes
Drawtool.java 에서는 switch로 나눠져서 중첩되어 있는 부분을 하나로 합쳐 위의 그림과 같이 수정하여 complexity가 작아지도록 하였다.
Page 10: OSP 3rd Cycle Presentation - Konkukdslab.konkuk.ac.kr/.../Team_project/7th/T3_Presentation.pdf · 2013-06-14 · OSP 3. rd. Cycle (VAT Paint) – T3. Clover – Treemap, Cloud Report

OSP 3rd Cycle (VAT Paint) – T3

Sonar

Violated Rules

Less Comments

Duplicate Codes

Magic Numbers

Public Valuables

High Complexity

10 / 20

Response to Static Analysis

Presenter
Presentation Notes
Sonar로 소스코드에 대한 전반적인 품질을 검사
Page 11: OSP 3rd Cycle Presentation - Konkukdslab.konkuk.ac.kr/.../Team_project/7th/T3_Presentation.pdf · 2013-06-14 · OSP 3. rd. Cycle (VAT Paint) – T3. Clover – Treemap, Cloud Report

OSP 3rd Cycle (VAT Paint) – T3

Sonar Less Comments, Duplicate Codes, Magic Numbers

11 / 20

Response to Static Analysis

Page 12: OSP 3rd Cycle Presentation - Konkukdslab.konkuk.ac.kr/.../Team_project/7th/T3_Presentation.pdf · 2013-06-14 · OSP 3. rd. Cycle (VAT Paint) – T3. Clover – Treemap, Cloud Report

OSP 3rd Cycle (VAT Paint) – T3

Sonar Public Valuables

12 / 20

Response to Static Analysis

Page 13: OSP 3rd Cycle Presentation - Konkukdslab.konkuk.ac.kr/.../Team_project/7th/T3_Presentation.pdf · 2013-06-14 · OSP 3. rd. Cycle (VAT Paint) – T3. Clover – Treemap, Cloud Report

OSP 3rd Cycle (VAT Paint) – T3

Sonar High Complexity

13 / 20

Response to Static Analysis

Removed ‘switch’ construction

Removed ‘if-else’ construction

Page 14: OSP 3rd Cycle Presentation - Konkukdslab.konkuk.ac.kr/.../Team_project/7th/T3_Presentation.pdf · 2013-06-14 · OSP 3. rd. Cycle (VAT Paint) – T3. Clover – Treemap, Cloud Report

OSP 3rd Cycle (VAT Paint) – T3

Sonar Additional Violated Rules

Improper Local Variable Name

Unused Local Variable

If Else Statements Not Using Braces( { } )

String Literal Equality ( ‘==‘ instead of ‘equals()’ )

14 / 20

Response to Static Analysis

Presenter
Presentation Notes
Sonar로 소스코드에 대한 전반적인 품질을 검사
Page 15: OSP 3rd Cycle Presentation - Konkukdslab.konkuk.ac.kr/.../Team_project/7th/T3_Presentation.pdf · 2013-06-14 · OSP 3. rd. Cycle (VAT Paint) – T3. Clover – Treemap, Cloud Report

Unit Test

15 / 20 15 / 20

Page 16: OSP 3rd Cycle Presentation - Konkukdslab.konkuk.ac.kr/.../Team_project/7th/T3_Presentation.pdf · 2013-06-14 · OSP 3. rd. Cycle (VAT Paint) – T3. Clover – Treemap, Cloud Report

OSP 3rd Cycle (VAT Paint) – T3

Unit Test

16 / 20

Page 17: OSP 3rd Cycle Presentation - Konkukdslab.konkuk.ac.kr/.../Team_project/7th/T3_Presentation.pdf · 2013-06-14 · OSP 3. rd. Cycle (VAT Paint) – T3. Clover – Treemap, Cloud Report

Concluding Team Project

17 / 20

Page 18: OSP 3rd Cycle Presentation - Konkukdslab.konkuk.ac.kr/.../Team_project/7th/T3_Presentation.pdf · 2013-06-14 · OSP 3. rd. Cycle (VAT Paint) – T3. Clover – Treemap, Cloud Report

OSP 3rd Cycle (VAT Paint) – T3

Concluding Team Project OSP UML JUnit

SVN

CruiseControl

Mantis

18 / 20

Page 19: OSP 3rd Cycle Presentation - Konkukdslab.konkuk.ac.kr/.../Team_project/7th/T3_Presentation.pdf · 2013-06-14 · OSP 3. rd. Cycle (VAT Paint) – T3. Clover – Treemap, Cloud Report

Q&A

19 / 20

Page 20: OSP 3rd Cycle Presentation - Konkukdslab.konkuk.ac.kr/.../Team_project/7th/T3_Presentation.pdf · 2013-06-14 · OSP 3. rd. Cycle (VAT Paint) – T3. Clover – Treemap, Cloud Report

Thank You

20 / 20