gerrit code review - the introduction

Download Gerrit Code Review - The Introduction

If you can't read please download the document

Upload: dariusz-luksza

Post on 26-May-2015

644 views

Category:

Technology


2 download

DESCRIPTION

Short introduction to Gerrit Code Review

TRANSCRIPT

2. Git?!Copyright 2012 Dariusz uksza 3. What is Gerrit?Git serverGerritHTTP serverSSH server Copyright 2012 Dariusz uksza 4. Why use code view? Early catch of common errors: NullPoinerException Code duplication Deprecated code use Typos Code design review Improve team knowledge about project Can be used as knowledge baseCopyright 2012 Dariusz uksza 5. Who uses Gerrit? Copyright 2012 Dariusz uksza 6. Gerrit @ Eclipse Foundation Copyright 2012 Dariusz uksza 7. What is needed to use it? Gerrit server git with additional configuration proper refspec commit message hook or EGitCopyright 2012 Dariusz uksza 8. What is refspec?$ git push :example: $ git push origin fix-npe:master $ git push origin fix-npe:refs/for/masteror configure this as default push action for repository:$ git configure remote.origin.push HEAD:refs/for/masterOr use EGit and Push to Gerrit action.Copyright 2012 Dariusz uksza 9. What is commit hook? Script executed by git after commit operation Gerrit commit hook adds Change-Id meta data It is project independent so after fetching fromserver for one project you can copy it locally Or use EGit and dont bother about hooks. Copyright 2012 Dariusz uksza 10. Lets create first review request$ git init$ scp -p -P 29418 :hooks/commit-msg .git/hooks/$ echo first review > readme.txt$ git add readme.txt$ git commit -m my first commit$ git logcommit 0a60797abd716298c6f6f8eb641451ae507eb9bfAuthor: Dariusz Luksza Date: Tue Nov 20 11:20:13 2012 +0100my first commitChange-Id: I871f6b4c500c96f4f7a91abf236f76b00d9057ca$ git push origin HEAD:refs/for/master Copyright 2012 Dariusz uksza 11. Lets create first review request$ git init$ scp -p -P 29418 @:hooks/commit-msg .git/hooks/$ echo first review > readme.txt$ git add readme.txt$ git commit -m my first commit$ git logcommit 0a60797abd716298c6f6f8eb641451ae507eb9bfAuthor: Dariusz Luksza Date: Tue Nov 20 11:20:13 2012 +0100my first commitChange-Id: I871f6b4c500c96f4f7a91abf236f76b00d9057ca$ git push origin HEAD:refs/for/masterCopyright 2012 Dariusz uksza 12. Lets create first review request$ git init$ scp -p -P 29418 @:hooks/commit-msg .git/hooks/$ echo first review > readme.txt$ git add readme.txt$ git commit -m my first commit$ git logcommit 0a60797abd716298c6f6f8eb641451ae507eb9bfAuthor: Dariusz Luksza Date: Tue Nov 20 11:20:13 2012 +0100my first commitChange-Id: I871f6b4c500c96f4f7a91abf236f76b00d9057ca$ git push origin HEAD:refs/for/masterCopyright 2012 Dariusz uksza 13. Lets create first review request$ git init$ scp -p -P 29418 @:hooks/commit-msg .git/hooks/$ echo first review > readme.txt$ git add readme.txt$ git commit -m my first commit$ git logcommit 0a60797abd716298c6f6f8eb641451ae507eb9bfAuthor: Dariusz Luksza Date: Tue Nov 20 11:20:13 2012 +0100my first commitChange-Id: I871f6b4c500c96f4f7a91abf236f76b00d9057ca$ git push origin HEAD:refs/for/masterCopyright 2012 Dariusz uksza 14. Lets create first review request$ git init$ scp -p -P 29418 @:hooks/commit-msg .git/hooks/$ echo first review > readme.txt$ git add readme.txt$ git commit -m my first commit$ git logcommit 0a60797abd716298c6f6f8eb641451ae507eb9bfAuthor: Dariusz Luksza Date: Tue Nov 20 11:20:13 2012 +0100my first commitChange-Id: I871f6b4c500c96f4f7a91abf236f76b00d9057ca$ git push origin HEAD:refs/for/masterCopyright 2012 Dariusz uksza 15. Lets create first review request$ git init$ scp -p -P 29418 @:hooks/commit-msg .git/hooks/$ echo first review > readme.txt$ git add readme.txt$ git commit -m my first commit$ git logcommit e6762c9a59c1bda7118633e4c2ddabf4ecca2152Author: Dariusz Luksza Date: Tue Nov 20 11:20:13 2012 +0100my first commitChange-Id: I5e9f2d410fdf37d2e20bedc162b2fb9565988a56$ git push origin HEAD:refs/for/masterCopyright 2012 Dariusz uksza 16. Lets create first review request$ git init$ scp -p -P 29418 @:hooks/commit-msg .git/hooks/$ echo first review > readme.txt$ git add readme.txt$ git commit -m my first commit$ git logcommit e6762c9a59c1bda7118633e4c2ddabf4ecca2152Author: Dariusz Luksza Date: Tue Nov 20 11:20:13 2012 +0100my first commitChange-Id: I5e9f2d410fdf37d2e20bedc162b2fb9565988a56$ git push origin HEAD:refs/for/masterCopyright 2012 Dariusz uksza 17. Lets create first review request$ git init$ scp -p -P 29418 @:hooks/commit-msg .git/hooks/$ echo first review > readme.txt$ git add readme.txt$ git commit -m my first commit$ git logcommit e6762c9a59c1bda7118633e4c2ddabf4ecca2152Author: Dariusz Luksza Date: Tue Nov 20 11:20:13 2012 +0100my first commitChange-Id: I5e9f2d410fdf37d2e20bedc162b2fb9565988a56$ git push origin HEAD:refs/for/masterCopyright 2012 Dariusz uksza 18. Lets create first review request$ git init$ scp -p -P 29418 @:hooks/commit-msg .git/hooks/$ echo first review > readme.txt$ git add readme.txt$ git commit -m my first commit$ git logcommit e6762c9a59c1bda7118633e4c2ddabf4ecca2152Author: Dariusz Luksza Date: Tue Nov 20 11:20:13 2012 +0100my first commitChange-Id: I5e9f2d410fdf37d2e20bedc162b2fb9565988a56$ git push origin HEAD:refs/for/masterCopyright 2012 Dariusz uksza 19. Lets create first review request$ git init$ scp -p -P 29418 @:hooks/commit-msg .git/hooks/$ echo first review > readme.txt$ git add readme.txt$ git commit -m my first commit$ git logcommit e6762c9a59c1bda7118633e4c2ddabf4ecca2152Author: Dariusz Luksza Date: Tue Nov 20 11:20:13 2012 +0100my first commitChange-Id: I5e9f2d410fdf37d2e20bedc162b2fb9565988a56$ git push origin HEAD:refs/for/masterCopyright 2012 Dariusz uksza 20. Lets create first review request$ git init$ scp -p -P 29418 @:hooks/commit-msg .git/hooks/$ echo first review > readme.txt$ git add readme.txt$ git commit -m my first commit$ git logcommit e6762c9a59c1bda7118633e4c2ddabf4ecca2152Author: Dariusz Luksza Date: Tue Nov 20 11:20:13 2012 +0100my first commitChange-Id: I5e9f2d410fdf37d2e20bedc162b2fb9565988a56$ git push ssh://@:29418/ HEAD:refs/for/master Copyright 2012 Dariusz uksza 21. Lets create first review request$ git init$ scp -p -P 29418 @:hooks/commit-msg .git/hooks/$ echo first review > readme.txt$ git add readme.txt$ git commit -m my first commit$ git logcommit e6762c9a59c1bda7118633e4c2ddabf4ecca2152Author: Dariusz Luksza Date: Tue Nov 20 11:20:13 2012 +0100my first commitChange-Id: I5e9f2d410fdf37d2e20bedc162b2fb9565988a56$ git push ssh://@:29418/ HEAD:refs/for/master Copyright 2012 Dariusz uksza 22. Lets create first review request$ git init$ scp -p -P 29418 @:hooks/commit-msg .git/hooks/$ echo first review > readme.txt$ git add readme.txt$ git commit -m my first commit$ git logcommit e6762c9a59c1bda7118633e4c2ddabf4ecca2152Author: Dariusz Luksza Date: Tue Nov 20 11:20:13 2012 +0100my first commitChange-Id: I5e9f2d410fdf37d2e20bedc162b2fb9565988a56$ git push ssh://@:29418/ HEAD:refs/for/master Copyright 2012 Dariusz uksza 23. Lets create first review request$ git init$ scp -p -P 29418 @:hooks/commit-msg .git/hooks/$ echo first review > readme.txt$ git add readme.txt$ git commit -m my first commit$ git logcommit e6762c9a59c1bda7118633e4c2ddabf4ecca2152Author: Dariusz Luksza Date: Tue Nov 20 11:20:13 2012 +0100my first commitChange-Id: I5e9f2d410fdf37d2e20bedc162b2fb9565988a56$ git push ssh://@:29418/ HEAD:refs/for/master Copyright 2012 Dariusz uksza 24. Lets create first review request$ git init$ scp -p -P 29418 @:hooks/commit-msg .git/hooks/$ echo first review > readme.txt$ git add readme.txt$ git commit -m my first commit$ git logcommit e6762c9a59c1bda7118633e4c2ddabf4ecca2152Author: Dariusz Luksza Date: Tue Nov 20 11:20:13 2012 +0100my first commitChange-Id: I5e9f2d410fdf37d2e20bedc162b2fb9565988a56$ git push ssh://@:29418/ HEAD:refs/for/master Copyright 2012 Dariusz uksza 25. Lets create first review request$ git init$ scp -p -P 29418 @:hooks/commit-msg .git/hooks/$ echo first review > readme.txt$ git add readme.txt$ git commit -m my first commit$ git logcommit e6762c9a59c1bda7118633e4c2ddabf4ecca2152Author: Dariusz Luksza Date: Tue Nov 20 11:20:13 2012 +0100my first commitChange-Id: I5e9f2d410fdf37d2e20bedc162b2fb9565988a56$ git push ssh://@:29418/ HEAD:refs/for/masterCopyright 2012 Dariusz uksza 26. Review change in Web UI m o d eiv eLCopyright 2012 Dariusz uksza 27. Add inline commentsmod e iveL Copyright 2012 Dariusz uksza 28. Amend change mo d e iveL Copyright 2012 Dariusz uksza 29. Vote on change mo d e iveLCopyright 2012 Dariusz uksza 30. Submit changemod e iveLCopyright 2012 Dariusz uksza 31. Gerrit ACL Read Push Push merge commit Push annotated tag Label code review (-2 to +2) Label verified (-1 to +1) Create reference (aka create branch) Abandon Edit topic Forge author identity Forge committer identity Forge server identity Rebase Remove reviewerCopyright 2012 Dariusz uksza 32. Gerrit Plugability Plugins Plugins Extensions Prolog rules for change validationCopyright 2012 Dariusz uksza 33. Review from EclipseCopyright 2012 Dariusz uksza 34. Introduction to Gerrit Dariusz uksza [email protected]@dlukszaUseful links: Git http://git-scm.com/ EGit http://eclipse.org/egit/ Gerrit http://gerrit.googlecode.com/ Mylyn reviews http://eclipse.org/reviews/gerrit/